fix(back-navigation): app freeze on going back in parent frame with s… · NativeScript/NativeScript@fc1f8c1 · GitHub

NativeScript / NativeScript Public

• Notifications You must be signed in to change notification settings
• Fork 1.7k
• Star 25.7k

• Code
• Issues 781
• Pull requests 74
• Discussions
• Actions
• Projects
• Wiki
• Security and quality
• Insights

Additional navigation options

Commit fc1f8c1

Browse filesBrowse the repository at this point in the historyBrowse files

ADjenkov

authored

fix(back-navigation): app freeze on going back in parent frame with states (#6595)

Endless loop while searching for parent frame that can go back. Caught in Angular app when trying to go back from nested named lazy loaded outlet using the android hadrware back button.

1 parent 33d6a64 commit fc1f8c1
Copy full SHA for fc1f8c1

1 file changed

+1-1Lines changed: 1 addition & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• tns-core-modules/ui/frame
  • frame-common.ts

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎tns-core-modules/ui/frame/frame-common.ts‎

Copy file name to clipboardExpand all lines: tns-core-modules/ui/frame/frame-common.ts

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -616,7 +616,7 @@ export function goBack(): boolean {
616	616	if (parentFrame && parentFrame.canGoBack()) {
617	617	parentFrameCanGoBack = true;
618	618	} else {
619		- parentFrame = <FrameBase>getAncestor(top, "Frame");
	619	+ parentFrame = <FrameBase>getAncestor(parentFrame, "Frame");
620	620	}
621	621	}
622	622

0 commit comments

Comments

0 (0)