fix(animations): check if target is present before removing its animation - #4586
Merged
vakrilov merged 1 commit intoJul 25, 2017
Merged
vakrilov merged 1 commit into
vakrilov merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…tion In Angular, if the NativeScriptAnimationModule is imported in another NgModule more than once (which shouldn't be done), the renderer is instantiated twice. This causes animation with empty targets to be created. If such animation is removed, the app will crash. Additional check if the target is present will prevent this.
vakrilov
approved these changes
Jul 24, 2017
Copy link
Copy Markdown
Contributor
|
run ci |
Sorry, something went wrong.
Copy link
Copy Markdown
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewer3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In NativeScript Angular, if the NativeScriptAnimationModule is imported in another
NgModule more than once (which shouldn't be done), the renderer will be instantiated twice. This
causes animations with empty targets to be created. If such animation is
removed, the app will crash. The additional check if the target is present
will prevent this.