feat: Register ./app.css instead of app.css so it can be provided by webpack context - #5158
Merged
PanayotCankov merged 1 commit intoDec 12, 2017
Merged
PanayotCankov merged 1 commit into
PanayotCankov merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…webpack context
This will let us register the app.css in webpack from a context, and potentially
have a configuration such as:
```
const appCssContext = require.context("~/", false, /^\.\/app\.(css|scss|less|sass)$/);
global.registerWebpackModules(appCssContext);
```
That will work with all of the app.css, app.scss, app.less etc. without further manual reconfiguration.
Copy link
Copy Markdown
Contributor
|
uitests |
Sorry, something went wrong.
vakrilov
approved these changes
Dec 12, 2017
Copy link
Copy Markdown
Contributor
|
testsappng |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@PanayotCankov, it looks like the builds are fine. Just ignore the single test failure, it is not related to this PR. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewerAssignees
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will let us register the app.css in webpack from a context, and potentially
have a configuration such as:
const appCssContext = require.context("~/", false, /^\.\/app\.(css|scss|less|sass)$/); global.registerWebpackModules(appCssContext);That will work with all of the app.css, app.scss, app.less etc. without further manual reconfiguration.