FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(ios): fire onDisplayed event when first frame is ready to be displayed by sis0k0 · Pull Request #5344 · NativeScript/NativeScript · GitHub

feat(ios): fire onDisplayed event when first frame is ready to be displayed - #5344

Merged
vakrilov merged 3 commits into
masterfrom
profiling-lifecycle-ios
Jan 29, 2018
Merged

vakrilov merged 3 commits into
masterfrom
profiling-lifecycle-ios

Conversation

sis0k0 commented Jan 27, 2018
edited
Loading

Copy link
Copy Markdown
Contributor

This PR is just the iOS part of #5316.

sis0k0 requested a review from PanayotCankov January 27, 2018 12:05
ghost assigned sis0k0 Jan 27, 2018
ghost added the in progress label Jan 27, 2018

Copy link
Copy Markdown
Contributor

cuteness

Copy link
Copy Markdown
Contributor

👍
Tests looks fine so far, ping @PanayotCankov.

Copy link
Copy Markdown
Contributor

test

1 similar comment

Copy link
Copy Markdown
Contributor

test

vakrilov merged commit 1c78e47 into master Jan 29, 2018
vakrilov deleted the profiling-lifecycle-ios branch January 29, 2018 11:47
sis0k0 added a commit that referenced this pull request Feb 5, 2018
…played (#5344)

* feat: add a 'profiling: lifecycle' to track startup times

* feat: log when displayed event fires

* feat(ios): fire onDisplayed event when first frame is ready to be
displayed
vakrilov pushed a commit that referenced this pull request Feb 13, 2018
* refactor: Handle TS2.7 stricter tuples checks (#5366)

* feat(ios): fire onDisplayed event when first frame is ready to be displayed (#5344)

* feat: add a 'profiling: lifecycle' to track startup times

* feat: log when displayed event fires

* feat(ios): fire onDisplayed event when first frame is ready to be
displayed

* chore: bump version to 3.4.1
dtopuzov added this to the 3.4.1 milestone Feb 20, 2018

lock Bot commented Aug 26, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

lock Bot locked and limited conversation to collaborators Aug 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL