FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(android/text ios/text): allow -1 to be a valid binding value by shiv19 · Pull Request #5563 · NativeScript/NativeScript · GitHub

/ NativeScript Public

fix(android/text ios/text): allow -1 to be a valid binding value - #5563

Merged
vakrilov merged 2 commits into
NativeScript:masterfrom
shiv19:shiv19/fix-issue5559
Mar 21, 2018
ConversationCommits (2)ChecksFiles changed
Merged

fix(android/text ios/text): allow -1 to be a valid binding value#5563
vakrilov merged 2 commits into
NativeScript:masterfrom
shiv19:shiv19/fix-issue5559

Conversation

shiv19 commented Mar 19, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

Instead of using -1 as a special value, use Symbol(-1)
so that it can't be reset accidentally

Closes issue #5559

PR Checklist

What is the current behavior?

#5559

What is the new behavior?

Replaced -1 with Symbol(-1) so that it reset can't be set accidentally

Fixes/Implements/Closes #[Issue Number].

#5556

fix(android/text ios/text): allow -1 to be a valid binding value
8739de6 
Instead of using -1 as special value, use Symbol(-1)
so that it can't be reset accidentally

Closes issue #5559

ns-bot commented Mar 19, 2018

Copy link
Copy Markdown

Can one of the admins verify this patch?

2 similar comments

ns-bot commented Mar 19, 2018

Copy link
Copy Markdown

Can one of the admins verify this patch?

ns-bot commented Mar 19, 2018

Copy link
Copy Markdown

Can one of the admins verify this patch?

ghost added the ♥ community PR label Mar 19, 2018
DimitarTachev approved these changes Mar 19, 2018
View reviewed changes

DimitarTachev left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

💯

shiv19 commented Mar 19, 2018 •
edited
Loading

Copy link
Copy Markdown
Member Author

I ran the tests.

All the tests have passed :)

And this PR doesn't require any new test case.

vakrilov self-assigned this Mar 19, 2018

vakrilov commented Mar 21, 2018

Copy link
Copy Markdown
Contributor

test

vakrilov merged commit 7cd8e7e into NativeScript:master Mar 21, 2018
ghost removed the ♥ community PR label Mar 21, 2018

lock Bot commented Aug 26, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

lock Bot locked and limited conversation to collaborators Aug 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
DimitarTachev DimitarTachev approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

vakrilov

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL