fix(ios-searchbar): fix crash with auto-sized searchbar in iOS11 Fixes #5655 - #5658
Merged
manoldonev merged 2 commits intoApr 12, 2018
Merged
manoldonev merged 2 commits into
manoldonev merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
manoldonev
force-pushed
the
mdonev/searchbar-ios-layout-fix
branch
from
460a4a3 to
0197ee1
Compare
April 11, 2018 16:01
manoldonev
force-pushed
the
mdonev/searchbar-ios-layout-fix
branch
from
0197ee1 to
090b1b5
Compare
April 11, 2018 16:07
Copy link
Copy Markdown
Contributor
Author
|
@SvetoslavTsenov Added new test page for UI test app ^^^ |
Sorry, something went wrong.
vakrilov
approved these changes
Apr 12, 2018
manoldonev
force-pushed
the
mdonev/searchbar-ios-layout-fix
branch
from
1058a28 to
1a6fc6e
Compare
April 12, 2018 08:58
Copy link
Copy Markdown
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewerAssignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently iOS11 SDK does not support passing sizeThatFits(...) non-finite width value any more.
In a scenario where searchbar should be auto-sized(grid with auto column) our measure logic always passes infinity values in case layout mode is unspecified so we extend the UISearchBar widget and add the fix there.