fix(android-textfield): returnPress fired twice for GO/SEARCH/SEND actions - #5727
Merged
manoldonev merged 13 commits intoMay 16, 2018
Merged
manoldonev merged 13 commits into
manoldonev merged 13 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
5 tasks
Copy link
Copy Markdown
Contributor
Author
|
test |
Sorry, something went wrong.
MartoYankov
approved these changes
Apr 26, 2018
Copy link
Copy Markdown
Contributor
|
test |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
test |
Sorry, something went wrong.
1 similar comment
Copy link
Copy Markdown
Contributor
|
test |
Sorry, something went wrong.
Copy link
Copy Markdown
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewerAssignees
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4461
It seems Android fires a complementary IME_ACTION_UNSPECIFIED action each time IME_ACTION_GO, IME_ACTION_SEARCH, or IME_ACTION_SEND is fired. As we need the IME_ACTION_UNSPECIFIED logic for a different fix (#5121) the proposal is to remove the explicit GO/SEARCH/SEND checks and handle them through the IME_ACTION_UNSPECIFIED.
Tested this change on physical Google Pixel and Samsung S8 phone, as well as on emulators with API levels 22, 23, and 25.