FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

TabView styling and css inheritance · Issue #5803 · NativeScript/NativeScript · GitHub

TabView styling and css inheritance #5803

Description

Problem: There are no separate elements for the tab content and the tab strip item. The TabViewItem element wraps both. This breaks css inheritance - the css is applied to both content and tab strip, but you can't override the css separately.

There are also some discrepancies between properties and between platforms:

  • font-size and text-transform have native implementations on TabViewItem, color doesn't. There is however tab-text-color which applies color to all tab strip items.
  • text-transform is for some reason not an inherited property
  • font-size is hard coded for iOS TabViewItems to 10.

Proposed solution:
As a rule I think inherited css properties shouldn't have implementations on elements that are not separately represented in the mark up.

  • Make text-transform inherited as per CSS spec.
  • Remove font-size and text-transform from TabViewItem.
  • Introduce new properties in their place on both TabView and TabViewItem tab-text-font-size and tab-text-transform.
  • Optionally introduce more font properties, e.g. tab-text-font, tab-text-font-style, tab-text-font-family.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions


      Back | FazBrowse Home | New Git URL