fix(Image): catch Response content may not be converted to an Image - #5856
Merged
vakrilov merged 4 commits intoJun 13, 2018
Merged
vakrilov merged 4 commits into
vakrilov merged 4 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
NathanWalker
force-pushed
the
fix-image-handling
branch
2 times, most recently
from
f160a68 to
3b7de48
Compare
May 27, 2018 05:13
NathanWalker
force-pushed
the
fix-image-handling
branch
from
3b7de48 to
a380a6b
Compare
May 30, 2018 02:51
vakrilov
self-requested a review
May 30, 2018 15:16
NathanWalker
force-pushed
the
fix-image-handling
branch
from
a380a6b to
182e076
Compare
May 30, 2018 20:55
NathanWalker
force-pushed
the
fix-image-handling
branch
from
182e076 to
01a67b8
Compare
June 1, 2018 01:03
Copy link
Copy Markdown
Contributor
|
test |
Sorry, something went wrong.
vakrilov
approved these changes
Jun 6, 2018
Copy link
Copy Markdown
Contributor
|
test |
Sorry, something went wrong.
Copy link
Copy Markdown
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewerAssignees
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes NativeScript/nativescript-angular#851
addresses part of #3381
PR Checklist
What is the current behavior?
Apps fail when this error occurs.
What is the new behavior?
Developers can now have a meaningful and productive debugging session to make great apps. Error is now properly caught and with tracing enabled with Debug category developers may now easily pick up these types of issues.
closes NativeScript/nativescript-angular#851
addresses part of #3381