FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(typings): Adding android typings for API levels from 17 to 27 by vtrifonov · Pull Request #5890 · NativeScript/NativeScript · GitHub

feat(typings): Adding android typings for API levels from 17 to 27 - #5890

Merged
vakrilov merged 14 commits into
masterfrom
trifonov/typings-improvements
Jul 5, 2018
Merged

vakrilov merged 14 commits into
masterfrom
trifonov/typings-improvements

Conversation

Copy link
Copy Markdown
Contributor

No description provided.

ghost assigned vtrifonov May 30, 2018
ghost added the in progress label May 30, 2018

Copy link
Copy Markdown
Contributor

test

vtrifonov changed the title Adding android typings for API levels from 17 to 27 [Do not ,erge Adding android typings for API levels from 17 to 27 Jun 14, 2018
vtrifonov changed the title [Do not ,erge Adding android typings for API levels from 17 to 27 [Do not Merge] Adding android typings for API levels from 17 to 27 Jun 14, 2018
vtrifonov changed the title [Do not Merge] Adding android typings for API levels from 17 to 27 [Do not merge] Adding android typings for API levels from 17 to 27 Jun 14, 2018
vtrifonov changed the title [Do not merge] Adding android typings for API levels from 17 to 27 Adding android typings for API levels from 17 to 27 Jun 28, 2018
ghost assigned vchimev Jun 28, 2018
vtrifonov changed the title Adding android typings for API levels from 17 to 27 [Do not merge yet]Adding android typings for API levels from 17 to 27 Jul 3, 2018
vtrifonov changed the title [Do not merge yet]Adding android typings for API levels from 17 to 27 Adding android typings for API levels from 17 to 27 Jul 3, 2018
vtrifonov requested a review from vakrilov July 3, 2018 09:19

vakrilov commented Jul 4, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

There are a couple of changed interfaces (problem we have changed the way we generate interfaces). Here are the instances we have renamed in the code, but probably there are more in the definitions that we are just not using. We should list this as a breaking change for the tns-platfrom-declarations package:

  • android.content.ISharedPreferences -> android.content.SharedPreferences
  • android.view.IMenuItem -> android.view.MenuItem
  • android.content.IDialogInterface -> android.content.DialogInterface
  • android.text.IEditable -> android.text.Editable
  • android.os.IIBinder -> android.os.IBinder
  • android.animation.Animator.IAnimatorListener -> android.animation.Animator.AnimatorListener

Copy link
Copy Markdown
Contributor Author

That's how the interface is named in Java, so I think this is the proper way of using it. How do we mark the breaking changes in the tns-platform-declarations package?

ghost assigned vakrilov Jul 4, 2018

Copy link
Copy Markdown
Contributor

unit-tests for css parser are failing to build

NativeScript@ unit-test /home/travis/build/NativeScript/NativeScript
tsc -p tsconfig.unit-tests.json && mocha --opts unit-tests/mocha.opts
tns-core-modules/ui/frame/transition-definitions.d.ts(8,51): error TS2694: Namespace 'android' has no exported member 'animation'.

vakrilov commented Jul 4, 2018

Copy link
Copy Markdown
Contributor

@vtrifonov I agree - interfaces are defined without the I in the android code, so having them this way is better. Still we must mark this as a change in case someone is using them. You canmark thi change as breaking with following the the commit message format (footer).

vakrilov commented Jul 5, 2018

Copy link
Copy Markdown
Contributor

test

Copy link
Copy Markdown
Collaborator

I see the same issue in this new definitions that I see in the existing one (17). Some constructors like android.content.ServiceConnection are written to need an implementation parameter.
This is wrong and they should be removed

vakrilov changed the title Adding android typings for API levels from 17 to 27 feat(typings): Adding android typings for API levels from 17 to 27 Jul 5, 2018
vakrilov merged commit 398c9b3 into master Jul 5, 2018
ghost removed the in progress label Jul 5, 2018
vakrilov deleted the trifonov/typings-improvements branch July 5, 2018 15:36

lock Bot commented Aug 26, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

lock Bot locked and limited conversation to collaborators Aug 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL