FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(list-view): Layout list-view items on request by vakrilov · Pull Request #6159 · NativeScript/NativeScript · GitHub

fix(list-view): Layout list-view items on request - #6159

Merged
vakrilov merged 6 commits into
masterfrom
list-items-layout
Aug 9, 2018
Merged

vakrilov merged 6 commits into
masterfrom
list-items-layout

Conversation

vakrilov commented Aug 7, 2018
edited
Loading

Copy link
Copy Markdown
Contributor

PR Checklist

What is the current behavior?

IOS: Layout for views inside list-view template was not triggered whenever a property that requires layout is changed or you call requestLayout() manually.

What is the new behavior?

ListView will now do a layout pass for its current items.

Note: Changing the height of list-view-cell is still not supported.

Related to NativeScript/nativescript-angular#377

ghost assigned vakrilov Aug 7, 2018
ghost added the in progress label Aug 7, 2018
vakrilov requested a review from MartoYankov August 7, 2018 14:06
ns-bot added the cla: yes label Aug 7, 2018
vakrilov merged commit ec24c5a into master Aug 9, 2018
ghost removed the in progress label Aug 9, 2018
vakrilov deleted the list-items-layout branch August 9, 2018 15:20
vakrilov pushed a commit that referenced this pull request Sep 11, 2018
* test: list items relayout example

* fix(list-view): Layout list-view items on request

* refactor(tests): refactor list-view tests imports

lock Bot commented Aug 26, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

lock Bot locked and limited conversation to collaborators Aug 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL