FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(iOS): Safe Area Support by vchimev · Pull Request #6230 · NativeScript/NativeScript · GitHub

feat(iOS): Safe Area Support - #6230

Merged
vchimev merged 186 commits into
masterfrom
ios-safe-area
Sep 28, 2018
Merged

vchimev merged 186 commits into
masterfrom
ios-safe-area

Conversation

vchimev commented Aug 31, 2018
edited
Loading

Copy link
Copy Markdown
Contributor

PR Checklist

What is the current behavior?

All container components and all content components layout in the safe area.

What is the new behavior?

All container components stretch outside the iOS safe area and have all content components layout in the safe area. This basically means the backgrounds of the container components will be seen to the limits of the screen.

Implements #5746.

MartoYankov and others added 30 commits August 28, 2018 18:10
Update `nativescript-dev-webpack` dependencies.
Delete `*-nav-page.*` files reproducing the issue.
Update `home-page.xml` with `ScrollView` to reproduce the issue.
Update styles -> `app.css`.
Update structure -> `home/home-page.xml`.
Add Grid + Wrap examples.

vchimev commented Sep 27, 2018

Copy link
Copy Markdown
Contributor Author

--ignore ios11 groceries_ios testsappng_ios ng_animation_examples_ios cuteness_ios

Copy link
Copy Markdown
Contributor

test

MartoYankov added the docs needed Additional documentation on this issue/PR is needed label Sep 28, 2018
vchimev merged commit 982acdc into master Sep 28, 2018
ghost removed the in progress label Sep 28, 2018
vchimev deleted the ios-safe-area branch September 28, 2018 15:21
NickIliev removed the docs needed Additional documentation on this issue/PR is needed label Jan 11, 2019

lock Bot commented Jan 11, 2020

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

lock Bot locked and limited conversation to collaborators Jan 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL