FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: Page and Frame isLoaded undefined checks by vakrilov · Pull Request #6255 · NativeScript/NativeScript · GitHub

fix: Page and Frame isLoaded undefined checks - #6255

Merged
dtopuzov merged 2 commits into
releasefrom
NathanWalker-fix-suspend-resume-isloaded-release
Sep 13, 2018
Merged

dtopuzov merged 2 commits into
releasefrom
NathanWalker-fix-suspend-resume-isloaded-release

Conversation

Copy link
Copy Markdown
Contributor

Based on #6187 by @NathanWalker
Resloves #6179

PR Checklist

What is the current behavior?

App's can randomly crash when various bindings update upon resuming an app dependent upon a wide array of possible view setups via developers.

What is the new behavior?

Guards have been added to account for various troubling race conditions.

closes #6179

ghost assigned vakrilov Sep 11, 2018
ghost added the in progress label Sep 11, 2018
vakrilov force-pushed the NathanWalker-fix-suspend-resume-isloaded-release branch from 61e1ad1 to 94669c1 Compare September 11, 2018 11:32

Copy link
Copy Markdown
Contributor

test

dtopuzov merged commit 4a11cf9 into release Sep 13, 2018
ghost removed the in progress label Sep 13, 2018
vakrilov deleted the NathanWalker-fix-suspend-resume-isloaded-release branch September 13, 2018 13:53
vakrilov pushed a commit that referenced this pull request Sep 17, 2018
* fix(view): isLoaded handling

closes #6179

* refactor: Error handling code in onCreateView

Copy link
Copy Markdown

this was solved in which version?

lock Bot commented Oct 8, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

lock Bot locked and limited conversation to collaborators Oct 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants


Back | FazBrowse Home | New Git URL