fix: nested fragments interact thru child fragment manager - #6293
manoldonev merged 8 commits into
Conversation
Sorry, something went wrong.
| import { Background, ad as androidBackground } from "../../styling/background"; | ||
| import { profile } from "../../../profiling"; | ||
| import { topmost } from "../../frame/frame-stack"; | ||
| import { topmost } from "../../frame"; |
There was a problem hiding this comment.
If I remember correctly, the reason for the separate frame-stack file and import was to avoid circular dependencies. Is this problem fixed now?
Sorry, something went wrong.
There was a problem hiding this comment.
Not sure but I'll revert that.
Sorry, something went wrong.
| // - tabview -> frame1 (frame1 uses tabview item CHILD fm) | ||
| // - frame1 -> tabview (tabview uses frame1 CHILD fm) | ||
| // - frame1 -> tabview -> frame2 (tabview uses frame1 CHILD fm; frame2 uses tabview item CHILD fm) | ||
| if (view.typeName === "Frame" || view.typeName === "TabView") { |
There was a problem hiding this comment.
I think the typeName will be wrong (and won't work) with uglify. The other property cssType that is set via the decorator might work, but it doesn't look right to use it.
What do you think about having a method _hasFragments() that returns true for TabView and Frame ?
Sorry, something went wrong.
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sorry, something went wrong.
Fixes #6292
TODO: review tab fragments' logic with respect to this change (and how did it work so far in the first place).