FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: Don't crash on missing resources in tab-view and action-bar by vakrilov · Pull Request #6388 · NativeScript/NativeScript · GitHub

fix: Don't crash on missing resources in tab-view and action-bar - #6388

Merged
vakrilov merged 4 commits into
masterfrom
fix-resoures-crashes
Oct 11, 2018
Merged

vakrilov merged 4 commits into
masterfrom
fix-resoures-crashes

Conversation

Copy link
Copy Markdown
Contributor

Referring missing icons in ActionBar and TabView items should not cause crashes. They should log a console error with the name of the missing resource instead.

vakrilov requested a review from MartoYankov October 11, 2018 13:38
ghost assigned vakrilov Oct 11, 2018
ghost added the in progress label Oct 11, 2018
ghost assigned SvetoslavTsenov Oct 11, 2018
ghost assigned MartoYankov Oct 11, 2018
vakrilov merged commit 56a1b12 into master Oct 11, 2018
ghost removed the in progress label Oct 11, 2018
vakrilov deleted the fix-resoures-crashes branch October 11, 2018 18:31

lock Bot commented Oct 11, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

lock Bot locked and limited conversation to collaborators Oct 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL