fix(list-view-android): app crashes on ListView item template change - #6634
Merged
ADjenkov merged 6 commits intoJan 8, 2019
Merged
ADjenkov merged 6 commits into
ADjenkov merged 6 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
ADjenkov
force-pushed
the
djenkov/list-view-templates
branch
from
535d277 to
86629dc
Compare
November 28, 2018 13:58
ADjenkov
force-pushed
the
djenkov/list-view-templates
branch
from
d122373 to
ee46d3d
Compare
November 29, 2018 14:18
manoldonev
approved these changes
Dec 6, 2018
vakrilov
approved these changes
Jan 7, 2019
SvetoslavTsenov
pushed a commit
that referenced
this pull request
Jan 13, 2019
…6634) * fix(list-view): app crashes on first ListView item template change * tests: add tests for changing ListView item template with expression
Copy link
Copy Markdown
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
2 more reviewers4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_itemTemplateSelector is called multiple times for Android because of the getItemViewType method which sets the bindingContext of itemTemplateSelector to the tapped dataItem on itemTap. After that some dataItem property is changed in itemTap user method and the bindingContext will point to that same dataItem reference without reevaluating the expression.
Added tests for dynamically changing ListView item template with itemTemplateSelector expression.
Fix #6284