FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(ios): resize of scrollview content breaks layout by MartoYankov · Pull Request #6965 · NativeScript/NativeScript · GitHub

/ NativeScript Public

fix(ios): resize of scrollview content breaks layout - #6965

Merged
MartoYankov merged 1 commit into
releasefrom
myankov/dynamic-size-scrollview
Feb 28, 2019
ConversationCommits (1)ChecksFiles changed
Merged

fix(ios): resize of scrollview content breaks layout#6965
MartoYankov merged 1 commit into
releasefrom
myankov/dynamic-size-scrollview

Conversation

MartoYankov commented Feb 27, 2019

Copy link
Copy Markdown
Contributor

Fixes #6915

Added one new e2e test - scroll-view/layout-outside-scroll. Steps:

  1. Tap on Scroll To Bottom.
  2. Tap on Change w/ Visibility. This will hide both the label at the bottom and the label at the top of the scroll view.
  3. Tap on Scroll To Top.
  4. Verify layout is okay.

MartoYankov self-assigned this Feb 27, 2019
cla-bot Bot added the cla: yes label Feb 27, 2019
ghost added the in progress label Feb 27, 2019

MartoYankov commented Feb 27, 2019

Copy link
Copy Markdown
Contributor Author

test package_version#latest

MartoYankov commented Feb 27, 2019

Copy link
Copy Markdown
Contributor Author

test package_version#latest

MartoYankov merged commit a9d2043 into release Feb 28, 2019
ghost removed the in progress label Feb 28, 2019
MartoYankov deleted the myankov/dynamic-size-scrollview branch February 28, 2019 08:20
MartoYankov added a commit that referenced this pull request Feb 28, 2019
Merge pull request #6970 from NativeScript/myankov/merge-release-master
ab437e1 
fix(ios): resize of scrollview content breaks layout (#6965)

lock Bot commented Mar 10, 2020

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

lock Bot locked and limited conversation to collaborators Mar 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

vchimev Awaiting requested review from vchimev
manoldonev Awaiting requested review from manoldonev
1 more reviewer
ADjenkov ADjenkov approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

MartoYankov

Labels

cla: yes patch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL