feat(HMR): style views at runtime - #7012
Merged
vchimev merged 3 commits intoMar 13, 2019
Merged
vchimev merged 3 commits into
vchimev merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
3 tasks
vchimev
force-pushed
the
vchimev/style-view
branch
from
277db23 to
11aefb6
Compare
March 11, 2019 11:51
MartoYankov
approved these changes
Mar 11, 2019
Copy link
Copy Markdown
Contributor
|
We should add some more e2e hmr tests. For example, changing the CSS of TabView as root. |
Sorry, something went wrong.
vchimev
force-pushed
the
vchimev/style-view
branch
2 times, most recently
from
11aefb6 to
4c143cc
Compare
March 12, 2019 13:08
manoldonev
reviewed
Mar 12, 2019
Comment thread
tests/app/testRunner.ts
manoldonev
approved these changes
Mar 12, 2019
test: module root view comopnent test: update livesync tests refactor: _onLivesync function
vchimev
force-pushed
the
vchimev/style-view
branch
from
4c143cc to
b8e87ed
Compare
March 12, 2019 15:48
vchimev
force-pushed
the
vchimev/style-view
branch
from
b8e87ed to
f9edb1b
Compare
March 12, 2019 15:51
Copy link
Copy Markdown
|
The cla-bot has been summoned, and re-checked this pull request! |
Sorry, something went wrong.
Copy link
Copy Markdown
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
Assignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
A change in styles applies at runtime only for a Frame root applications.
What is the new behavior?
This pull request enables changes in styles to apply at runtime, no matter of the root application: layouts, Frame, TabView or SideDrawer.
Implements a part of #6953.