fix(text): crash when removing FormattedText - #7237
Merged
vakrilov merged 2 commits intoMay 13, 2019
Merged
vakrilov merged 2 commits into
vakrilov merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
ADjenkov
approved these changes
May 13, 2019
Copy link
Copy Markdown
Contributor
|
test sdk_ng |
Sorry, something went wrong.
manoldonev
approved these changes
May 13, 2019
Copy link
Copy Markdown
Contributor
|
test sdk_ng |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
test sdk_ng nativescript-angular#/tns-dist/nativescript-angular/PR/fac8bf7c5491842e48a15a06c86121a59ec58b8b/nativescript-angular-7.2.4.tgz |
Sorry, something went wrong.
manoldonev
pushed a commit
that referenced
this pull request
May 15, 2019
* fix(text): crash when removing FormattedText * refactor: fixed crash on ios too
Copy link
Copy Markdown
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
2 more reviewersAssignees
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
See NativeScript/nativescript-angular#1818
What is the new behavior?
App no longer crashes
Fixes NativeScript/nativescript-angular#1818