fix: clear the resolvedPage when entry is being cleared, change the passed View to be a weak reference - #7327
Merged
dtopuzov merged 8 commits intoJun 21, 2019
Merged
dtopuzov merged 8 commits into
dtopuzov merged 8 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
fix: change the passed `View` to be a weak reference
5 tasks
…g to be used chore: add condition to check if weak ref has not been cleared when it is being used
manoldonev
reviewed
Jun 18, 2019
Comment thread
tns-core-modules/ui/styling/style/style.d.ts
Copy link
Copy Markdown
Contributor
|
test |
Sorry, something went wrong.
manoldonev
reviewed
Jun 19, 2019
Comment thread
tns-core-modules/ui/core/properties/properties.ts
manoldonev
reviewed
Jun 19, 2019
Comment thread
tns-core-modules/ui/core/properties/properties.ts
Outdated
chore: add tracelogs
manoldonev
reviewed
Jun 19, 2019
Comment thread
tns-core-modules/ui/core/properties/properties.ts
Outdated
manoldonev
reviewed
Jun 19, 2019
Comment thread
tns-core-modules/ui/core/properties/properties.ts
Outdated
manoldonev
reviewed
Jun 19, 2019
Comment thread
tns-core-modules/ui/styling/style-scope.ts
Outdated
manoldonev
reviewed
Jun 19, 2019
Comment thread
tns-core-modules/ui/styling/style-scope.ts
Outdated
manoldonev
approved these changes
Jun 19, 2019
Copy link
Copy Markdown
Contributor
Author
|
test |
Sorry, something went wrong.
2 similar comments
Copy link
Copy Markdown
Contributor
|
test |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
test |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
test package_version#latest |
Sorry, something went wrong.
1 similar comment
Copy link
Copy Markdown
Contributor
|
test package_version#latest |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
test |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 more reviewersAssignees
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
When navigating to a Page that contains any kind of elements (GridLayout, ListView, RadListView etc.), if you navigate back and trigger JS GC those elements and the Page itself are never collected and stay in the memory.
What is the new behavior?
When navigating to a Page that contains any kind of elements (GridLayout, ListView, RadListView etc.), if you navigate back and trigger JS GC those elements and the Page itself are collected and are removed from the memory.
Fixes/Implements/Closes #[Issue Number].
Here is a sample project that I created to test this case:
memory-test.zip