fix(android): ignore gzip content-encoding for 204 status code - #7417
Merged
manoldonev merged 2 commits intoJun 28, 2019
Merged
manoldonev merged 2 commits into
manoldonev merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
test |
Sorry, something went wrong.
manoldonev
approved these changes
Jun 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
A HTTP request that responds with a 204: No Content status and has 'Content-Encoding': 'gzip' header set, throws a java.io.EOFException on Android. This results in the request failing with a null statusCode, null statusText and null headers. This doesn't occur on iOS.
What is the new behavior?
gzip encoding is ignored if the response status is 204. Response correctly resolves.
Fixes #7375.