fix(timer): setTimeout/setInterval support for boolean period - #7569
Merged
vakrilov merged 7 commits intoAug 2, 2019
Merged
vakrilov merged 7 commits into
vakrilov merged 7 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
vakrilov
suggested changes
Jul 24, 2019
Comment thread
tns-core-modules/timer/timer.d.ts
Outdated
vakrilov
approved these changes
Jul 25, 2019
vakrilov
approved these changes
Jul 25, 2019
Copy link
Copy Markdown
Contributor
|
test |
Sorry, something went wrong.
manoldonev
approved these changes
Jul 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 more reviewersAssignees
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
setTimeout/setInterval can't be called with Boolean period.
What is the new behavior?
setTimeout/setInterval can be called with a Boolean period - cast to either 0 or 1.
Fixes/Implements/Closes #7567.