feat: apply styles when adding them to the application scope - #7652
Merged
vchimev merged 3 commits intoAug 13, 2019
Merged
vchimev merged 3 commits into
vchimev merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
vchimev
force-pushed
the
vchimev/application-styles
branch
4 times, most recently
from
392d1c4 to
b0c047c
Compare
August 7, 2019 20:13
MartoYankov
reviewed
Aug 12, 2019
Comment thread
e2e/ui-tests-app/app/app.css
Comment thread
tns-core-modules/application/application.android.ts
MartoYankov
approved these changes
Aug 12, 2019
Currently, when adding styles to the application scope, they do not apply until `_onCssStateChagne()` executes.
This is to verify that adding new application styles applies immediately. The test needs to tap on the `#app` button and reuses the current image for verification.
vchimev
force-pushed
the
vchimev/application-styles
branch
from
b0c047c to
835067b
Compare
August 12, 2019 13:25
Move `styles-page` from `button` to `css` folder. Add `css` suite and `styles` spec.
vchimev
force-pushed
the
vchimev/application-styles
branch
from
835067b to
8f38474
Compare
August 12, 2019 13:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
There are addCss() methods for Application and the ViewCommon class.
Currently, Application.addCss() does not execute _onCssStateChagne() as ViewCommon.addCss() does.
Therefore, the application styles scope updates, however, the added styles do not apply until navigation or _onCssStateChagne() executes.
What is the new behavior?
Application.addCss() to execute _onCssStateChagne().
In this way, it applies the added application styles immediately.