FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: introduce fixed font icons to tab navigation by MartoYankov · Pull Request #7691 · NativeScript/NativeScript · GitHub

feat: introduce fixed font icons to tab navigation - #7691

Merged
manoldonev merged 10 commits into
masterfrom
myankov/tab-icon-size
Aug 22, 2019
Merged

manoldonev merged 10 commits into
masterfrom
myankov/tab-icon-size

Conversation

Copy link
Copy Markdown
Contributor

Add new property fixedIcons that defaults to true that fixes icon sizes to the spec size - 24x24 with max width 31 and max height 28 allowed. Set to false to use the actual size of the images.

MartoYankov self-assigned this Aug 18, 2019
cla-bot Bot added the cla: yes label Aug 18, 2019
manoldonev added the docs needed Additional documentation on this issue/PR is needed label Aug 19, 2019

manoldonev commented Aug 20, 2019
edited
Loading

Copy link
Copy Markdown
Contributor

@MartoYankov Android Bottom Navigation icon change scenario still does not look OK out-of-the-box but we'll investigate it after feature freeze (will log it).

manoldonev commented Aug 20, 2019
edited
Loading

Copy link
Copy Markdown
Contributor

@MartoYankov iOS Bottom Navigation font icons scenario -- third font icon gets clipped upon activation (will log it):


Copy link
Copy Markdown
Contributor

@MartoYankov iOS Tabs font icons scenario looks broken -- font icon color is wrong (will log it):

Copy link
Copy Markdown
Contributor

@MartoYankov iOS tabs icon change scenario still does not change the icon (will log it):

Copy link
Copy Markdown
Contributor Author

@manoldonev

  1. First one should be investigated.

  2. Regarding the clipped icon - I believe this is expected. If you look closely the icon is clipped before the tab item is activated too. This is the case when the font is wrong and doesn't support icons. It's not an issue with the scaling, but with the font itself. If you do this in a Label the result will be the same.

  3. Regarding the iOS Tabs icon colors, this is a decision/limitation I imposed. Since the color property can't apply on the titles (because of MDCTabBar limitation) I disabled it on the icons as well. Now for both the color property value of the TabStrip is the valid one. It's possible to do it for the icons since they are simply images, but looks weird.

Copy link
Copy Markdown
Contributor

test api19

manoldonev merged commit 8039c2c into master Aug 22, 2019
manoldonev deleted the myankov/tab-icon-size branch August 22, 2019 07:26

Copy link
Copy Markdown
Contributor

@MartoYankov is the last (fourth) issue also a limitation of the MDCTabBar usage (about iOS tabs icon change example not working) or should I log it?

rigor789 removed the docs needed Additional documentation on this issue/PR is needed label Oct 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL