FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(css-calc): reduce_css_calc_1.default is not a function by m-abs · Pull Request #7787 · NativeScript/NativeScript · GitHub

/ NativeScript Public

fix(css-calc): reduce_css_calc_1.default is not a function - #7787

Merged
manoldonev merged 1 commit into
NativeScript:masterfrom
m-abs:fix/7786-css-calc-broken
Sep 10, 2019
ConversationCommits (1)ChecksFiles changed
Merged

fix(css-calc): reduce_css_calc_1.default is not a function#7787
manoldonev merged 1 commit into
NativeScript:masterfrom
m-abs:fix/7786-css-calc-broken

Conversation

m-abs commented Sep 5, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

PR Checklist

What is the current behavior?

"reduce-css-calc" is imported via default export, breaks in published tns-core-modules@6.1.0.

Causes errors like this:

JS: Error: Failed to evaluate css-calc for property [font-size] for expression [calc(18 * 1)] to Button(7)@main-page.xml:29:9;. TypeError: reduce_css_calc_1.default is not a function
JS:     at Object._evaluateCssCalcExpression (file:///node_modules/tns-core-modules/ui/core/properties/properties.js:85:0)
JS:     at evaluateCssExpressions (file:///node_modules/tns-core-modules/ui/styling/style-scope.js:40:0)
JS:     at CssState.push.../node_modules/tns-core-modules/ui/styling/style-scope.js.CssState.setPropertyValues (file:///node_modules/tns-core-modules/ui/styling/style-scope.js:460:0)
JS:     at file:///node_modules/tns-core-modules/ui/styling/style-scope.js:381:0
JS:     at Button.push.../node_modules/tns-core-modules/ui/core/view-base/view-base.js.ViewBase._batchUpdate (file:///node_modules/tns-core-modules/ui/core/view-base/view-base.js:279:0)
JS:     at CssState.push.../node_modules/tns-core-modules/ui/styling/style-scope.js.CssState.updateDynamicState (file:///data/data/org.nativescript.testycore/files/app/vendor.js:333...

What is the new behavior?

import reduceCSSCalc from "reduce-css-calc";
... to ...
import * as reduceCSSCalc from "reduce-css-calc";

Fixes: #7786

cla-bot Bot added the cla: yes label Sep 5, 2019
manoldonev changed the base branch from master to release September 5, 2019 16:42
manoldonev changed the base branch from release to master September 5, 2019 16:42

manoldonev commented Sep 5, 2019

Copy link
Copy Markdown
Contributor

test

manoldonev merged commit 03d1ff0 into NativeScript:master Sep 10, 2019
manoldonev pushed a commit that referenced this pull request Sep 10, 2019
fix(css-calc): reduce_css_calc_1.default is not a function (#7787)
9f1ba72
manoldonev mentioned this pull request Sep 10, 2019
Merged
m-abs deleted the fix/7786-css-calc-broken branch September 10, 2019 11:55
manoldonev added a commit that referenced this pull request Sep 10, 2019
fix(css-calc): reduce_css_calc_1.default is not a function (#7787) (#…
20c0773 
…7801)
manoldonev added a commit that referenced this pull request Sep 12, 2019
chore: merge release to master (#7809)
e0c4933 
* feat(android): fix tab resource icon size based on spec (#7737)

* feat(ios): add icon rendering mode for bottom navigation (#7738)

* fix(ios-tabs): crash when add tabstrip in loaded event (#7743)

* fix(css): parse css selectors with escape sequences (#7689) (#7732)

* fix(ios-tabs): handle nesting proxy view container (#7755)

* fix-next(css): className to preserve root views classes (#7725)

* docs: cut the 6.1.0 release (#7773)

* fix(android-list-picker): NoSuchFieldException on api29 (#7790)

* chore: hardcode tslib version to 1.10.0 (#7776)

* fix(css-calc): reduce_css_calc_1.default is not a function (#7787) (#7801)
m-abs restored the fix/7786-css-calc-broken branch November 27, 2019 20:49
m-abs deleted the fix/7786-css-calc-broken branch November 27, 2019 20:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
manoldonev manoldonev approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes ♥ community PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

css-calc is broken i 6.1.0

2 participants

Back | FazBrowse Home | New Git URL