feat: ES modules (ESM) support with conditional esm or commonjs consumption - #1836
Merged
NathanWalker merged 27 commits intoNov 5, 2025
Merged
feat: ES modules (ESM) support with conditional esm or commonjs consumption#1836NathanWalker merged 27 commits into
NathanWalker merged 27 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…l-esm-consumption
Cases where the same java classname would result causing a name collision.
…pha testing largely
NathanWalker
marked this pull request as draft
September 7, 2025 18:11
NathanWalker
marked this pull request as ready for review
October 23, 2025 17:08
Copy link
Copy Markdown
There was a problem hiding this comment.
Pull Request Overview
This PR adds ES module (ESM) support to the NativeScript Android runtime, enabling the use of .mjs files alongside traditional CommonJS .js files. The implementation includes conditional detection of ES modules, dynamic import support, import.meta functionality, and enhanced Worker constructor capabilities.
Key Changes:
- Native C++ implementation for ES module loading, resolution, and callbacks (import.meta, dynamic imports)
- Java-side module resolution updated to handle .mjs file extensions
- Test infrastructure modernized to verify results via console output instead of XML files
- Build tools updated to recognize and process .mjs files
Reviewed Changes
Copilot reviewed 27 out of 29 changed files in this pull request and generated 4 comments.
Show a summary per file| File | Description |
|---|---|
| test-app/runtime/src/main/cpp/ModuleInternalCallbacks.cpp | Implements ES module resolution callback, import.meta initialization, dynamic import support, and Node.js built-in polyfills |
| test-app/runtime/src/main/cpp/ModuleInternal.cpp | Adds LoadESModule function to compile and evaluate .mjs files with proper registry management |
| test-app/runtime/src/main/java/com/tns/Module.java | Updates file resolution to check for .mjs extensions alongside .js files |
| test-app/runtime/src/main/cpp/Runtime.cpp | Registers V8 callbacks for import.meta and dynamic import() |
| test-app/tools/check_console_test_results.js | New script to verify test results from console output instead of XML files |
| test-app/runtime/src/main/java/com/tns/AppConfig.java | Adds logScriptLoading configuration option |
| test-app/build-tools/static-binding-generator/src/main/java/org/nativescript/staticbindinggenerator/Generator.java | Updates binding generator to create unique identifiers for .mjs files |
| test-app/app/src/main/assets/app/tests/testESModules.js | Test suite validating ES module loading, import.meta, and Worker enhancements |
test-app/runtime/src/main/cpp/ModuleInternalCallbacks.cpp:1
- The regex pattern /\/+/g uses JavaScript literal syntax but this is C++ code generating a JavaScript polyfill string. The backslashes need to be escaped for the C++ string literal to produce the correct JavaScript regex. Should be \\/+ to properly escape the forward slash.
#include "ModuleInternal.h"
test-app/runtime/src/main/cpp/ModuleInternalCallbacks.cpp:1
- Incorrect comment: usleep(100) provides a 100 microsecond (0.1ms) delay, but the comment says '0.1ms delay' which is correct. However, note that usleep() is deprecated in POSIX.1-2008 and removed in POSIX.1-2001; consider using nanosleep() instead.
#include "ModuleInternal.h"
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sorry, something went wrong.
Comment thread
test-app/tools/check_console_test_results.js
Outdated
Comment thread
test-app/tools/check_console_test_results.js
Outdated
Comment thread
test-app/tools/check_console_test_results.js
Outdated
Comment thread
test-app/runtime/src/main/java/com/tns/Runtime.java
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…l-esm-consumption
triniwiz
reviewed
Nov 5, 2025
Comment thread
test-app/runtime/src/main/cpp/Version.h
NathanWalker
commented
Nov 5, 2025
Comment thread
test-app/runtime/src/main/cpp/Version.h
Outdated
NathanWalker
commented
Nov 5, 2025
Comment thread
test-app/runtime/src/main/cpp/Version.h
Outdated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backwards compatible.