feat: http loaded es module realms + HMR DX enrichments - #1883
Merged
NathanWalker merged 29 commits intoNov 11, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…l-esm-consumption
Cases where the same java classname would result causing a name collision.
…pha testing largely
…l-esm-consumption
…l-esm-consumption
Copy link
Copy Markdown
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors the ES module test system and adds HTTP-based ESM loading support with HMR (Hot Module Replacement) capabilities. The changes improve test result parsing, add support for loading ES modules from HTTP(S) URLs, and implement import.meta.hot for development-time module reloading.
Key changes:
- Rewrote ES module tests from CommonJS to native ESM format (.mjs)
- Enhanced test result checker with improved parsing and failure diagnostics
- Added HTTP(S) ESM loader with compile diagnostics and relative import resolution
- Implemented HMR support with import.meta.hot API
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.
Show a summary per file| File | Description |
|---|---|
| test-app/tools/check_console_test_results.js | Refactored test result parsing to extract structured ES module test summaries, removed tail command from logcat pipeline, improved test status tracking |
| test-app/runtime/src/main/cpp/ModuleInternalCallbacks.cpp | Added HTTP ESM loading, relative URL resolution, HMR support, and diagnostic logging for compile errors |
| test-app/runtime/src/main/cpp/HMRSupport.h | New header defining import.meta.hot API and HTTP fetch utilities |
| test-app/runtime/src/main/cpp/HMRSupport.cpp | Implements HMR callback registration, HTTP fetching via JNI, and URL canonicalization |
| test-app/runtime/src/main/cpp/DevFlags.h | New header for cached script loading log flag |
| test-app/runtime/src/main/cpp/DevFlags.cpp | Implements cached flag for script loading diagnostics |
| test-app/runtime/CMakeLists.txt | Added HMRSupport.cpp and DevFlags.cpp to build |
| test-app/app/src/main/assets/app/tests/testRuntimeImplementedAPIs.js | Improved __time test with better tolerance handling |
| test-app/app/src/main/assets/app/tests/testESModules.mjs | Rewrote tests as async ESM with improved error reporting |
| test-app/app/src/main/assets/app/tests/testESModules.js | Removed old CommonJS test file |
| test-app/app/src/main/assets/app/mainpage.js | Updated to require .mjs test file instead of .js |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sorry, something went wrong.
Comment thread
test-app/runtime/src/main/cpp/ModuleInternalCallbacks.cpp
Outdated
Comment thread
test-app/runtime/src/main/cpp/HMRSupport.cpp
Comment thread
test-app/tools/check_console_test_results.js
Comment thread
test-app/app/src/main/assets/app/tests/testESModules.mjs
Outdated
Comment thread
test-app/app/src/main/assets/app/tests/testESModules.mjs
Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and refactors related to ES module testing, runtime diagnostics, and internal development flags.
Runtime Diagnostics and Development Flags