| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
Inside the android {} block names resolve delegate-first, so the
`ndkVersion ndkVersion` argument reads the extension's own (empty)
value and assigns it back to itself. The -PndkVersion project property
never reaches AGP. Read it explicitly with project.ndkVersion so the
configured NDK is actually applied.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 4312aff2-d2fd-4c1d-baa6-a93026193771 📥 CommitsReviewing files that changed from the base of the PR and between a84d3c7 and b369e91. 📒 Files selected for processing (1)
📝 Walkthrough WalkthroughThe test-app/runtime/build.gradle file updates its Android NDK version configuration to source the version from project.ndkVersion property instead of referencing a direct variable, aligning the build configuration with Gradle property conventions. ChangesAndroid NDK Version Configuration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem🚥 Pre-merge checks | ✅ 5 ✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. ❤️ ShareComment @coderabbitai help to get the list of available commands and usage tips. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
While building the runtime with a custom NDK version I noticed it never actually took effect. It comes down to this in test-app/runtime/build.gradle:
if (hasNdkVersion) { ndkVersion ndkVersion }This was added in cbd0ab1 to forward a -PndkVersion property into the android DSL. The catch is that inside the android {} block Groovy resolves names against the extension first, so the ndkVersion argument hits the extension's own getter, which is still empty there, and the line just assigns that empty value back to itself. The project property is never read. The else branch only works because defaultNdkVersion isn't a property on the extension, so it falls through to script scope.
Reading it explicitly with project.ndkVersion fixes it. Easy to check: pass -PndkVersion=<something> and android.ndkVersion comes out empty before this change and holds the value after. It usually goes unnoticed because most builds take the else branch, and an empty ndkVersion just makes AGP fall back to a default NDK rather than failing.
Summary by CodeRabbit