Commit 33c7337
committed
chore: align branch with main tooling after rebase
- bump ts-jest to 29.4.12 so jest specs compile under TypeScript 6
(29.4.9 forced moduleResolution=node10, which TS 6 rejects)
- satisfy eslint 9 no-empty / no-empty-function / no-this-alias rules
now enforced by main's flat config1 parent f209a48 commit 33c7337
5 files changed
Lines changed: 37 additions & 11 deletions
File tree
- packages/angular/src/lib
- legacy/router
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -108,7 +108,7 @@ | |||
| 108 | 108 | "sass": "1.72.0", | |
| 109 | 109 | "sinon": "^17.0.0", | |
| 110 | 110 | "tailwindcss": "~3.4.0", | |
| 111 | - "ts-jest": "29.4.9", | ||
| 111 | + "ts-jest": "29.4.12", | ||
| 112 | 112 | "ts-node": "10.9.2", | |
| 113 | 113 | "tslib": "^2.8.0", | |
| 114 | 114 | "typescript": "6.0.3", | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -369,7 +369,9 @@ export function runNativeScriptAngularApp<T, K>(options: AppRunOptions<T, K>) { | |||
| 369 | 369 | NativeScriptDebug.hmrLog(`cleared Angular route caches before reboot: detachedViews=${clearedDetached} routeFields=${cleared} locationState=${JSON.stringify(clearedLocation)}`); | |
| 370 | 370 | } | |
| 371 | 371 | } | |
| 372 | - } catch {} | ||
| 372 | + } catch { | ||
| 373 | + // ignore | ||
| 374 | + } | ||
| 373 | 375 | }; | |
| 374 | 376 | const updatePlatformRef = (moduleRef: NgModuleRef<T | K> | ApplicationRef, reason: NgModuleReason) => { | |
| 375 | 377 | const newPlatformRef = moduleRef.injector.get(PlatformRef); | |
@@ -392,7 +394,9 @@ export function runNativeScriptAngularApp<T, K>(options: AppRunOptions<T, K>) { | |||
| 392 | 394 | ||
| 393 | 395 | try { | |
| 394 | 396 | (currentRoot as any)._onCssStateChange?.(); | |
| 395 | - } catch {} | ||
| 397 | + } catch { | ||
| 398 | + // ignore | ||
| 399 | + } | ||
| 396 | 400 | }, 0); | |
| 397 | 401 | }; | |
| 398 | 402 | const setRootView = (ref: NgModuleRef<T | K> | ApplicationRef | View) => { | |
@@ -815,7 +819,9 @@ export function runNativeScriptAngularApp<T, K>(options: AppRunOptions<T, K>) { | |||
| 815 | 819 | } | |
| 816 | 820 | try { | |
| 817 | 821 | global['__NS_CAPTURE_ANGULAR_HMR_ROUTE__']?.(); | |
| 818 | - } catch {} | ||
| 822 | + } catch { | ||
| 823 | + // ignore | ||
| 824 | + } | ||
| 819 | 825 | disposeLastModules('hotreload'); | |
| 820 | 826 | if (traceEnabled) { | |
| 821 | 827 | NativeScriptDebug.hmrLog(`after disposeLastModules cycle=${cycleNum} bootstrapId=${bootstrapId}`); | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -185,6 +185,7 @@ export class HmrCacheStore { | |||
| 185 | 185 | typeof requested === 'number' && requested > 0 | |
| 186 | 186 | ? Math.floor(requested) | |
| 187 | 187 | : 0; | |
| 188 | + // eslint-disable-next-line @typescript-eslint/no-empty-function | ||
| 188 | 189 | this._log = options.log ?? (() => {}); | |
| 189 | 190 | // Trim seed if it overshoots the configured ceiling — possible if | |
| 190 | 191 | // a previous session ran with a larger `maxEntries` than this one. | |
@@ -267,6 +268,7 @@ export class HmrCacheStore { | |||
| 267 | 268 | throw new Error('[HmrCacheStore] scope() requires a non-empty prefix'); | |
| 268 | 269 | } | |
| 269 | 270 | const fullPrefix = `${prefix}:`; | |
| 271 | + // eslint-disable-next-line @typescript-eslint/no-this-alias | ||
| 270 | 272 | const parent = this; | |
| 271 | 273 | return { | |
| 272 | 274 | prefix: fullPrefix, | |
@@ -356,6 +358,7 @@ export function createDefaultHmrCacheStore( | |||
| 356 | 358 | const invalidateEventName = | |
| 357 | 359 | options.invalidateEventName ?? DEFAULT_INVALIDATE_EVENT; | |
| 358 | 360 | const maxEntries = options.maxEntries ?? DEFAULT_MAX_ENTRIES; | |
| 361 | + // eslint-disable-next-line @typescript-eslint/no-empty-function | ||
| 359 | 362 | const log = options.log ?? (() => {}); | |
| 360 | 363 | ||
| 361 | 364 | const hot = readImportMetaHot(); | |
Lines changed: 6 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -18,7 +18,9 @@ function destroyRouteCacheValue(value: unknown): void { | |||
| 18 | 18 | if (typeof destroy === 'function') { | |
| 19 | 19 | try { | |
| 20 | 20 | destroy.call(value); | |
| 21 | - } catch {} | ||
| 21 | + } catch { | ||
| 22 | + // ignore | ||
| 23 | + } | ||
| 22 | 24 | } | |
| 23 | 25 | } | |
| 24 | 26 | ||
@@ -36,7 +38,9 @@ function clearRouteCacheField(route: Record<string, unknown>, key: (typeof ROUTE | |||
| 36 | 38 | } catch { | |
| 37 | 39 | try { | |
| 38 | 40 | route[key] = undefined; | |
| 39 | - } catch {} | ||
| 41 | + } catch { | ||
| 42 | + // ignore | ||
| 43 | + } | ||
| 40 | 44 | } | |
| 41 | 45 | ||
| 42 | 46 | return true; | |
0 commit comments