FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(list-view): fix crash when used with ngFor by edusperoni · Pull Request #2121 · NativeScript/nativescript-angular · GitHub

/ nativescript-angular Public

fix(list-view): fix crash when used with ngFor - #2121

Merged
NathanWalker merged 10 commits into
NativeScript:masterfrom
edusperoni:zone-fixes
Sep 4, 2020
ConversationCommits (10)ChecksFiles changed
Merged

fix(list-view): fix crash when used with ngFor#2121
NathanWalker merged 10 commits into
NativeScript:masterfrom
edusperoni:zone-fixes

Conversation

edusperoni commented Feb 12, 2020

Copy link
Copy Markdown
Collaborator

PR Checklist

What is the current behavior?

#1221 (comment)

What is the new behavior?

ListView now runs CD inside the ngzone, so no more conflicts with NS events occur.

Additional information

This is a workaround over a possibly more complicated issue:
#1221 (comment)

Fixes #1221 .

cla-bot Bot added the cla: yes label Feb 12, 2020
edusperoni changed the title Zone fixes fix(list-view): fix crash when used with ngFor Feb 12, 2020

cla-bot Bot commented Sep 3, 2020

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @edusperoni.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

cla-bot Bot removed the cla: yes label Sep 3, 2020

cla-bot Bot commented Sep 3, 2020

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @edusperoni.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

edusperoni commented Sep 3, 2020

Copy link
Copy Markdown
Collaborator Author

@cla-bot check

cla-bot Bot added the cla: yes label Sep 3, 2020

cla-bot Bot commented Sep 3, 2020

Copy link
Copy Markdown

The cla-bot has been summoned, and re-checked this pull request!

NathanWalker merged commit 302afb3 into NativeScript:master Sep 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read property 'destroyed' of null

2 participants

Back | FazBrowse Home | New Git URL