There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
Ordering can be erratic when nesting ng-containers and templates. This is due to previousSibling not being implemented and comment nodes not being properly respected
The node list is now doubly linked (previousSibling and nextSibling), allowing for faster processing of previousSibling and respecting the positioning of commentnodes.
bellalMohamed reacted with thumbs up emoji
bellalMohamed reacted with hooray emoji
bellalMohamed reacted with heart emoji
bellalMohamed reacted with rocket emoji
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Ordering can be erratic when nesting ng-containers and templates. This is due to previousSibling not being implemented and comment nodes not being properly respected
will render:
2
1
What is the new behavior?
The node list is now doubly linked (previousSibling and nextSibling), allowing for faster processing of previousSibling and respecting the positioning of commentnodes.
will render
1
2
Fixes/Implements/Closes #[Issue Number].