FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(renderer): order not preserved by edusperoni · Pull Request #2261 · NativeScript/nativescript-angular · GitHub

fix(renderer): order not preserved - #2261

Merged
NathanWalker merged 1 commit into
NativeScript:masterfrom
edusperoni:renderer-ordering-fix
Sep 21, 2020
Merged

fix(renderer): order not preserved#2261
NathanWalker merged 1 commit into
NativeScript:masterfrom
edusperoni:renderer-ordering-fix

Conversation

edusperoni commented Sep 21, 2020
edited
Loading

Copy link
Copy Markdown
Collaborator

PR Checklist

What is the current behavior?

Ordering can be erratic when nesting ng-containers and templates. This is due to previousSibling not being implemented and comment nodes not being properly respected

<ng-container>
  <Label text="1" *ngIf="show"></Label>
  <Label text="2" *ngIf="show"></Label>
</ng-container>

will render:

2
1

What is the new behavior?

The node list is now doubly linked (previousSibling and nextSibling), allowing for faster processing of previousSibling and respecting the positioning of commentnodes.

<ng-container>
  <Label text="1" *ngIf="show"></Label>
  <Label text="2" *ngIf="show"></Label>
</ng-container>

will render
1
2

Fixes/Implements/Closes #[Issue Number].

cla-bot Bot added the cla: yes label Sep 21, 2020
NathanWalker merged commit 07abb9e into NativeScript:master Sep 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL