fix: `The provided Android NDK is vnull while the recommended one is … · NativeScript/nativescript-dev-webpack@23aa6c5 · GitHub

This repository was archived by the owner on Aug 7, 2021. It is now read-only.

NativeScript / nativescript-dev-webpack Public archive

• Notifications You must be signed in to change notification settings
• Fork 40
• Star 97

• Code
• Issues 82
• Pull requests 3
• Actions
• Security and quality
• Insights

Additional navigation options

Commit 23aa6c5

Browse filesBrowse the repository at this point in the historyBrowse files

DimitarTachev

committed

fix: The provided Android NDK is vnull while the recommended one is v21.0.6113669 error in some cases

1 parent 8e47184 commit 23aa6c5
Copy full SHA for 23aa6c5

1 file changed

+5-1Lines changed: 5 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• snapshot/android
  • snapshot-generator.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎snapshot/android/snapshot-generator.js‎

Copy file name to clipboardExpand all lines: snapshot/android/snapshot-generator.js

+5-1Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -400,7 +400,11 @@ SnapshotGenerator.prototype.buildCSource = function (androidArch, blobInputDir,
400	400	}
401	401
402	402	SnapshotGenerator.prototype.getRecommendedNdkWarning = function (localNdkRevision, recommendedAndroidNdkRevision) {
403		- return `The provided Android NDK is v${localNdkRevision} while the recommended one is v${recommendedAndroidNdkRevision}`;
	403	+ if (localNdkRevision) {
	404	+ return `The provided Android NDK is v${localNdkRevision} while the required one is v${recommendedAndroidNdkRevision}`;
	405	+ } else {
	406	+ return `The provided Android NDK version is different than the required one - v${recommendedAndroidNdkRevision}`;
	407	+ }
404	408	}
405	409
406	410	SnapshotGenerator.prototype.runMksnapshotTool = function (tool, mksnapshotParams, inputFile, snapshotInDocker, snapshotToolsPath, buildCSource) {

0 commit comments

Comments

0 (0)