Fix pytype error when dynamically importing a python file. · NeoTim/python-spanner-orm@3af5eca · GitHub

NeoTim / python-spanner-orm Public

forked from google/python-spanner-orm

• Notifications You must be signed in to change notification settings
• Fork 0
• Star 0

• Code
• Pull requests
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 3af5eca

Browse filesBrowse the repository at this point in the historyBrowse files

dseomn

committed

Fix pytype error when dynamically importing a python file.

See google/pytype#319 for context on the error. Addresses google#93.

1 parent 7db9acb commit 3af5eca
Copy full SHA for 3af5eca

1 file changed

+3-4Lines changed: 3 additions & 4 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• spanner_orm/admin
  • migration_manager.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎spanner_orm/admin/migration_manager.py‎

Copy file name to clipboardExpand all lines: spanner_orm/admin/migration_manager.py

+3-4Lines changed: 3 additions & 4 deletions

Original file line number	Diff line number	Diff line change
@@ -72,10 +72,9 @@ def _migration_from_file(self, filename: str) -> migration.Migration:
72	72	"""Loads a single migration from the given filename in the base dir."""
73	73	module_name = re.sub(r'\W', '_', filename)
74	74	path = os.path.join(self.basedir, filename)
75		- spec = importlib.util.spec_from_file_location(module_name, path)
76		- module = importlib.util.module_from_spec(spec)
77		- # TODO(#93): Remove pytype disable below.
78		- spec.loader.exec_module(module) # type: ignore
	75	+ module = importlib.util.module_from_spec(
	76	+ importlib.util.spec_from_file_location(module_name, path))
	77	+ importlib.machinery.SourceFileLoader(module_name, path).exec_module(module)
79	78	try:
80	79	result = migration.Migration(module.migration_id,
81	80	module.prev_migration_id,

0 commit comments

Comments

0 (0)