[WIP] Find & solve concurrency issues - #738
Draft
MrIvanPlays wants to merge 9 commits into
Draft
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
MrIvanPlays
requested review from
PiggyPiglet and
extendedclip
as code owners
October 28, 2021 15:47
MrIvanPlays
marked this pull request as draft
October 28, 2021 15:47
This was modified by my IDE somehow
Issue PlaceholderAPI#727 's CME roots come from FileUtil. This can be due to the previous implementation having 2 lists linking each other. This is removing 1 of the lists and handling on-the-go while also cleaning up the code a bit. Oh, and for the CloudExpansionManager change: I put it on the wrong spot the first time :P so yea
Copy link
Copy Markdown
|
Thanks for taking this on. |
Sorry, something went wrong.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Type
Description
This is as of right now a tracking PR for any concurrency issues. I am going to try to find and resolve concurrency issues in PlaceholderAPI's code. This is not to be merge soon!
This is trying to resolve issues such as #727 ; a ConcurrentModificationException showing that either:
a) something is modifying something while looping
b) something is getting modified on thread y while it is already being modified on thread x