Move parsing method to PlaceholderExpansion - #824
Draft
Andre601 wants to merge 2 commits into
Draft
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Type
Description
This is a proposal to move the on(Placeholder)Request(...) from the separate PlaceholderHook class to the PlaceholderExpansion class.
The PlaceholderHook is somewhat useless now since it only is used for the aforementioned methods, which can easily be moved to the PlaceholderExpansion class without major issues.
To not have completely breaking changes are the new methods by default simply calling the now deprecated ones, but it should be encouraged to move on to the new methods.
I'll keep this a draft to prevent accidental merging and because I first want to have a discussion here to see the points in favour and against this change (It could also serve as a heads up, IF it would be accepted, so that devs knows what would come.