Dynamically count expected rules in GetScriptAnalyzerRule test (#2167) · PowerShell/PSScriptAnalyzer@f3e9134 · GitHub

PowerShell / PSScriptAnalyzer Public

• Notifications You must be signed in to change notification settings
• Fork 414
• Star 2.2k

• Code
• Issues 401
• Pull requests 22
• Discussions
• Actions
• Projects
• Wiki
• Security and quality
• Insights

Additional navigation options

Commit f3e9134

Browse filesBrowse the repository at this point in the historyBrowse files

andyleejordan

authored

Dynamically count expected rules in GetScriptAnalyzerRule test (#2167)

Replace hardcoded rule count with dynamic counting of [Export(typeof(I...Rule))] attributes in C# source files. This prevents the test from breaking every time a new rule is added.

1 parent 9d8a1fe commit f3e9134
Copy full SHA for f3e9134

1 file changed

+7-2Lines changed: 7 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• Tests/Engine
  • GetScriptAnalyzerRule.tests.ps1

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎Tests/Engine/GetScriptAnalyzerRule.tests.ps1‎

Copy file name to clipboardExpand all lines: Tests/Engine/GetScriptAnalyzerRule.tests.ps1

+7-2Lines changed: 7 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -63,8 +63,13 @@ Describe "Test Name parameters" {
63	63
64	64	It "get Rules with no parameters supplied" {
65	65	$defaultRules = Get-ScriptAnalyzerRule
66		- $expectedNumRules = 72
67		- $defaultRules.Count | Should -Be $expectedNumRules
	66	+ # Dynamically count the expected number of rules from source files
	67	+ # by finding all C# files with [Export(typeof(I...Rule))] attributes
	68	+ $rulesRoot = Resolve-Path "$PSScriptRoot/../../Rules"
	69	+ $expectedNumRules = (Get-ChildItem -Path $rulesRoot -Filter '*.cs' -Recurse |
	70	+ Select-String -Pattern 'Export\(typeof\s*\(I\w+Rule\)\)' |
	71	+ Select-Object -ExpandProperty Path -Unique).Count
	72	+ $defaultRules.Count | Should -Be $expectedNumRules
68	73	}
69	74
70	75	It "is a positional parameter" {

0 commit comments

Comments

0 (0)