FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Whitespace changes to better conform to jQuery coding standards, remo… · Pythoning/javascript-patterns@d34a297 · GitHub

/ javascript-patterns Public
forked from chuanxshi/javascript-patterns

Commit d34a297

Browse files
StevenBlack
committed
Whitespace changes to better conform to jQuery coding standards, removed the mix of spaces and tabs, adjusted line spacing in these two files for consistency of conceptual segmentation, and made changes to pass jsHint
The JQuery Core Style Guidelines can be found here: http://docs.jquery.com/JQuery_Core_Style_Guidelines Adjusted the in-code white-spacing for consistency -- prior to these changes there was no evident standard, or a standard had yet to be enforced. Chose to adhere to jQuery Core Style Guidelines because students studying jQuery will come across many examples authored by core team members who, on balance, tend towards this standard. Fixed one minor jsHint-discovered error, an unnecessary semicolon at the end of a function definition. Stripped-away all trailing spaces on code and blank lines. By the way, I like your use of the leading semicolon to guard against prior concatenated code. Signed-off-by: Steven Black <steveb@stevenblack.com>
1 parent e53a5be commit d34a297

2 files changed

Lines changed: 62 additions & 62 deletions

File tree

‎jquery-plugin-patterns/extend.html‎

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -17,32 +17,32 @@
1717
As you'll notice below, we're making use of $.fn.extend to create our plugin rather
1818
than opting for $.fn.pluginname. This type of structure may be useful if you need
1919
to add a relatively large number of methods to your plugin. There are however alternatives
20-
to this that may be better suited, including Alex Sexton's prototypal inheritence pattern
21-
which is also included in this repo.
20+
to this that may be better suited, including Alex Sexton's prototypal inheritence pattern
21+
which is also included in this repo.
2222
*/
2323

2424

25-
//the semi colon before function invocation is a safety net against concatenated
26-
//scripts and/or other plugins which may not be closed properly.
27-
;(function($){
28-
$.fn.extend({
29-
pluginname: function( options ) {
25+
// the semi colon before function invocation is a safety net against concatenated
26+
// scripts and/or other plugins which may not be closed properly.
27+
;( function( $ ){
28+
$.fn.extend( {
29+
pluginname: function( options ) {
3030

31-
this.defaultOptions = {};
31+
this.defaultOptions = {};
3232

33-
var settings = $.extend({}, this.defaultOptions, options);
33+
var settings = $.extend( {}, this.defaultOptions, options );
3434

35-
return this.each(function() {
35+
return this.each( function() {
3636

37-
var $this = $(this);
37+
var $this = $( this );
3838

39-
});
39+
});
4040

41-
}
42-
43-
});
41+
}
4442

45-
})(jQuery);
43+
});
44+
45+
})( jQuery );
4646

4747

4848
// References

‎jquery-plugin-patterns/namespaced-starter.html‎

Lines changed: 46 additions & 46 deletions
Original file line numberDiff line numberDiff line change
@@ -14,52 +14,52 @@
1414
*/
1515

1616
;(function ( $ ) {
17-
if (!$.myNamespace) {
18-
$.myNamespace = {};
19-
};
20-
21-
$.myNamespace.myPluginName = function ( el, myFunctionParam, options ) {
22-
// To avoid scope issues, use 'base' instead of 'this'
23-
// to reference this class from internal events and functions.
24-
var base = this;
25-
26-
// Access to jQuery and DOM versions of element
27-
base.$el = $(el);
28-
base.el = el;
29-
30-
// Add a reverse reference to the DOM object
31-
base.$el.data( "myNamespace.myPluginName" , base );
32-
33-
base.init = function () {
34-
base.myFunctionParam = myFunctionParam;
35-
36-
base.options = $.extend({},
37-
$.myNamespace.myPluginName.defaultOptions, options);
38-
39-
// Put your initialization code here
40-
};
41-
42-
// Sample Function, Uncomment to use
43-
// base.functionName = function( paramaters ){
44-
//
45-
// };
46-
// Run initializer
47-
base.init();
48-
};
49-
50-
$.myNamespace.myPluginName.defaultOptions = {
51-
myDefaultValue: ""
52-
};
53-
54-
$.fn.mynamespace_myPluginName = function
55-
( myFunctionParam, options ) {
56-
return this.each(function () {
57-
(new $.myNamespace.myPluginName(this,
58-
myFunctionParam, options));
59-
});
60-
};
61-
62-
})( jQuery );
17+
if ( ! $.myNamespace ) {
18+
$.myNamespace = {};
19+
}
20+
21+
$.myNamespace.myPluginName = function ( el, myFunctionParam, options ) {
22+
23+
// To avoid scope issues, use 'base' instead of 'this'
24+
// to reference this class from internal events and functions.
25+
var base = this;
26+
27+
// Access to jQuery and DOM versions of element
28+
base.$el = $( el );
29+
base.el = el;
30+
31+
// Add a reverse reference to the DOM object
32+
base.$el.data( "myNamespace.myPluginName" , base );
33+
34+
base.init = function () {
35+
base.myFunctionParam = myFunctionParam;
36+
37+
base.options = $.extend( {}, $.myNamespace.myPluginName.defaultOptions, options );
38+
39+
// Put your initialization code here
40+
41+
};
42+
43+
// Sample Function, Uncomment to use
44+
// base.functionName = function( paramaters ){
45+
//
46+
// };
47+
48+
// Run initializer
49+
base.init();
50+
};
51+
52+
$.myNamespace.myPluginName.defaultOptions = {
53+
myDefaultValue: ""
54+
};
55+
56+
$.fn.mynamespace_myPluginName = function( myFunctionParam, options ) {
57+
return this.each( function () {
58+
( new $.myNamespace.myPluginName( this, myFunctionParam, options ) );
59+
});
60+
};
61+
62+
} )( jQuery );
6363

6464

6565
// References

0 commit comments

Comments
 (0)
Back | FazBrowse Home | New Git URL