FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(mysql): SQL result-grid Save must use PK, types, and a transaction · Issue #804 · QueryaHub/Querya-Desktop · GitHub

fix(mysql): SQL result-grid Save must use PK, types, and a transaction #804

Description

Summary

mysql_sql_workspace._applyStagedChanges calls generateMutationPlan() without primaryKeys or columnDataTypes. WHERE is every displayed column. Fallback table name is the literal table. Statements run in a loop with no START TRANSACTION (Table Browser wraps a transaction). Mid-loop failure leaves a partial write.

Scope

  • Resolve a simple FROM via getTableSchema. If no PK or not a single-table SELECT, disable Save.
  • Pass columnDataTypes.
  • Wrap like Table Browser: START TRANSACTION / statements / COMMIT / ROLLBACK.
  • Tests: JOIN / FROM a, b do not mutate; simple SELECT * FROM db.t uses the PK.

Out of scope

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingdata-gridInteractive data grid, cell editor, filtering, groupingseditorCode/SQL editormysqlMySQL database driver and workspace

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions


      Back | FazBrowse Home | New Git URL