Repository navigation
Commit 03d090e
committed
fix: OrderedDict.get() crashes on wasi
- Problem: On wasi, OrderedDict.get() crashes with an out of bounds memory access
- Cause: OrderedDict uses by_hash: HashMap which requires 8 byte align
- Fix: Wrap by_hash in Box<HashMap<...>> to bring align back down to 4 bytes
Assisted-by: Claude Code:claude-sonnet-5
Signed-off-by: Jiwoo Ahn <ikwydls1314@gmail.com>1 parent 04eb0ad commit 03d090e
1 file changed
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -48,7 +48,7 @@ pub(crate) mod ordered_dict { | |||
| 48 | 48 | last: Option<usize>, | |
| 49 | 49 | nodes: Vec<Option<ODictNode>>, | |
| 50 | 50 | free: Vec<usize>, | |
| 51 | - by_hash: HashMap<PyHash, Vec<usize>>, | ||
| 51 | + by_hash: Box<HashMap<PyHash, Vec<usize>>>, | ||
| 52 | 52 | state: usize, | |
| 53 | 53 | } | |
| 54 | 54 | ||
@@ -573,6 +573,7 @@ pub(crate) mod ordered_dict { | |||
| 573 | 573 | fn __sizeof__(&self) -> usize { | |
| 574 | 574 | self.dict.__sizeof__() | |
| 575 | 575 | + core::mem::size_of::<ODictLinks>() | |
| 576 | + + core::mem::size_of::<HashMap<PyHash, Vec<usize>>>() | ||
| 576 | 577 | + self.links.lock().nodes.capacity() * core::mem::size_of::<Option<ODictNode>>() | |
| 577 | 578 | } | |
| 578 | 579 | ||
0 commit comments