Repository navigation
Commit 5c07fa4
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -42,7 +42,7 @@ repos: | |||
| 42 | 42 | ||
| 43 | 43 | - id: generate-rs-opcode-metadata | |
| 44 | 44 | name: generate rust opcode metadata | |
| 45 | - entry: python tools/opcode_metadata/generate_rs_opcode_metadata.py | ||
| 45 | + entry: python3 tools/opcode_metadata/generate_rs_opcode_metadata.py | ||
| 46 | 46 | files: '^(crates/compiler-core/src/bytecode/instruction\.rs|tools/opcode_metadata/*)$' | |
| 47 | 47 | pass_filenames: false | |
| 48 | 48 | language: system | |
@@ -53,7 +53,7 @@ repos: | |||
| 53 | 53 | ||
| 54 | 54 | - id: generate-py-opcode-metadata | |
| 55 | 55 | name: generate python opcode metadata | |
| 56 | - entry: python tools/opcode_metadata/generate_py_opcode_metadata.py | ||
| 56 | + entry: python3 tools/opcode_metadata/generate_py_opcode_metadata.py | ||
| 57 | 57 | files: '^(crates/compiler-core/src/bytecode/instruction\.rs|tools/opcode_metadata/*)$' | |
| 58 | 58 | pass_filenames: false | |
| 59 | 59 | language: system | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -372,12 +372,15 @@ impl PyList { | |||
| 372 | 372 | ||
| 373 | 373 | if let Some(index) = index.into() { | |
| 374 | 374 | // defer delete out of borrow | |
| 375 | - let is_inside_range = index < self.borrow_vec().len(); | ||
| 376 | - Ok(is_inside_range.then(|| self.borrow_vec_mut().remove(index))) | ||
| 375 | + let removed = { | ||
| 376 | + let mut elements = self.borrow_vec_mut(); | ||
| 377 | + (index < elements.len()).then(|| elements.remove(index)) | ||
| 378 | + }; | ||
| 379 | + drop(removed); | ||
| 380 | + Ok(()) | ||
| 377 | 381 | } else { | |
| 378 | 382 | Err(vm.new_value_error(format!("'{}' is not in list", needle.str(vm)?))) | |
| 379 | 383 | } | |
| 380 | - .map(drop) | ||
| 381 | 384 | } | |
| 382 | 385 | ||
| 383 | 386 | fn _delitem(&self, needle: &PyObject, vm: &VirtualMachine) -> PyResult<()> { | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1,4 +1,4 @@ | |||
| 1 | - #!/usr/bin/env python | ||
| 1 | + #!/usr/bin/env python3 | ||
| 2 | 2 | import argparse | |
| 3 | 3 | import ast | |
| 4 | 4 | import glob | |
0 commit comments