Commit b3d9b8d
Fix TypeError in git.execute(..., output_stream=file)
This fixes gitpython-developers#619 - raise GitCommandError(not TypeError) when output_stream is set
in git.execute1 parent e1d2f4b commit b3d9b8d
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -794,7 +794,7 @@ def _kill_process(pid): | |||
| 794 | 794 | else: | |
| 795 | 795 | max_chunk_size = max_chunk_size if max_chunk_size and max_chunk_size > 0 else io.DEFAULT_BUFFER_SIZE | |
| 796 | 796 | stream_copy(proc.stdout, output_stream, max_chunk_size) | |
| 797 | - stdout_value = output_stream | ||
| 797 | + stdout_value = proc.stdout.read() | ||
| 798 | 798 | stderr_value = proc.stderr.read() | |
| 799 | 799 | # strip trailing "\n" | |
| 800 | 800 | if stderr_value.endswith(b"\n"): | |
0 commit comments