FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Merge pull request #122 from therehello/bugfix_decode_rgba_leak · SDWebImage/SDWebImageWebPCoder@5f80930 · GitHub

Commit 5f80930

Browse files
authored
Merge pull request #122 from therehello/bugfix_decode_rgba_leak
Fix the leak of RGBA buffer when WebPDecode failed
2 parents 12d83ed + 74b78eb commit 5f80930

2 files changed

Lines changed: 2 additions & 1 deletion

File tree

‎SDWebImageWebPCoder/Classes/SDImageWebPCoder.m‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -627,6 +627,7 @@ - (nullable CGImageRef)sd_createWebpImageWithData:(WebPData)webpData colorSpace:
627627

628628
// Decode the WebP image data into a RGBA value array
629629
if (WebPDecode(webpData.bytes, webpData.size, &config) != VP8_STATUS_OK) {
630+
WebPFree(rgba);
630631
return nil;
631632
}
632633

‎Tests/SDWebImageWebPCoderTests.m‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -262,10 +262,10 @@ - (void)testWebPDecodeDoesNotTriggerCACopyImage {
262262
XCTAssertEqual(colorspace, NSScreen.mainScreen.colorSpace.CGColorSpace, @"Color space is not screen");
263263
#else
264264
XCTAssertEqual(colorspaceName, (__bridge NSString *)kCGColorSpaceSRGB, @"Color space is not sRGB");
265+
#endif
265266
} else {
266267
// Fallback on earlier versions
267268
}
268-
#endif
269269
}
270270

271271
- (void)testEncodingSettings {

0 commit comments

Comments
 (0)

Back | FazBrowse Home | New Git URL