Merge pull request #1271 from allcloud-jonathan/feature/honor-bool-fo… · Sineaggi/python-gitlab@1552eb5 · GitHub

1. Sineaggi
2. python-gitlab

Repository navigation

• Code
• Pull requests
• Actions
• Projects
• Security and quality
• Insights

Commit 1552eb5

Browse filesBrowse the repository at this point in the historyBrowse files

nejch

authored

Merge pull request python-gitlab#1271 from allcloud-jonathan/feature/honor-bool-for-delete-source

fix: honor parameter value passed

2 parents 07edafe + c2f8f0e commit 1552eb5
Copy full SHA for 1552eb5

1 file changed

+2-2Lines changed: 2 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• gitlab/v4/objects
  • merge_requests.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎gitlab/v4/objects/merge_requests.py‎

Copy file name to clipboardExpand all lines: gitlab/v4/objects/merge_requests.py

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -312,8 +312,8 @@ def merge(
312	312	data = {}
313	313	if merge_commit_message:
314	314	data["merge_commit_message"] = merge_commit_message
315		- if should_remove_source_branch:
316		- data["should_remove_source_branch"] = True
	315	+ if should_remove_source_branch is not None:
	316	+ data["should_remove_source_branch"] = should_remove_source_branch
317	317	if merge_when_pipeline_succeeds:
318	318	data["merge_when_pipeline_succeeds"] = True
319	319

0 commit comments

Comments

0 (0)