Heading correction (hC): The offset in heading (yaw) between the tracker's world reference and the headset's world reference
Attitude alignment (aA): The offset in attitude (pitch+roll) between the tracker's local reference and the bone's local reference
Heading alignment (hA): The offset in heading (yaw) between the tracker's local reference and the bone's local reference
In essence: Correction gives us the tracker's absolute orientation in the world, alignment translates the orientation to represent a fixed mounting on a rigidbody (limb).
Description
These tests added prove these five essential rules that define our calibration equation:
Heading correction may be applied at any time as long as it is on the left side of the orientation
Applying heading correction does not affect attitude calculation
The order that you apply attitude and heading alignment does matter (basic quaternion business, but nice to show)
By applying the inverse of the heading alignment as a heading correction, we can make the two variables independent
If we want to modify heading alignment independently, we must perform it after attitude alignment
or in a more user relatable context:
Yaw reset can be applied at any time in the math with no negative effects
Yaw reset doesn't affect full reset calculation (continuation of 1)
The order of applying full reset vs. mounting reset matters
We can change mounting reset whenever and not mess up yaw reset
Mounting reset must be applied after full reset, otherwise your full reset gets weird
These tests are purely for reference purposes and may be disabled if they cause significant slowdowns in test runs. No code has been implemented otherwise, but this lays the groundwork for development based on proven principles and basic concepts which may be built upon to create tests for our "reset" implementation. This should also serve as a reference for new contributors to learn how calibration works and the limitations of the math, and to reduce wasted time investigating bugs related to "reset" math when one of our basic rules can explicitly prove the behaviour even if the system itself is not tested.
tl;dr: People don't really understand quaternions, let's just show what works, how it works, and why it works.
This should also be extended to acceleration alignment at some point, though that is much easier to comprehend.
WIP
Comments could use some reconsideration
Terminology should be documented in the code
Basic example(s) of how these concepts may be applied to calculate the required "session calibrations"
Describe the dependencies of variables and how we manipulate the chain
Implement static body frame pitch/roll offsets (ex. t-pose reset)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loucass003
Awaiting requested review from loucass003
loucass003 will be requested when the pull request is marked ready for review
loucass003 is a code owner
Erimelowo
Awaiting requested review from Erimelowo
Erimelowo will be requested when the pull request is marked ready for review
Erimelowo is a code owner
At least 2 approving reviews are required to merge this pull request.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Terminology
In essence: Correction gives us the tracker's absolute orientation in the world, alignment translates the orientation to represent a fixed mounting on a rigidbody (limb).
Description
These tests added prove these five essential rules that define our calibration equation:
or in a more user relatable context:
These tests are purely for reference purposes and may be disabled if they cause significant slowdowns in test runs. No code has been implemented otherwise, but this lays the groundwork for development based on proven principles and basic concepts which may be built upon to create tests for our "reset" implementation. This should also serve as a reference for new contributors to learn how calibration works and the limitations of the math, and to reduce wasted time investigating bugs related to "reset" math when one of our basic rules can explicitly prove the behaviour even if the system itself is not tested.
tl;dr: People don't really understand quaternions, let's just show what works, how it works, and why it works.
This should also be extended to acceleration alignment at some point, though that is much easier to comprehend.
WIP