FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Portrait Mode (WIP) by IzaakBH · Pull Request #18 · ThePhoneProject/advanced-android-camera · GitHub

/ advanced-android-camera Public

Portrait Mode (WIP) - #18

Draft
IzaakBH wants to merge 30 commits into
mainfrom
portrait-mediapipe
ConversationCommits (30)ChecksFiles changed
Draft

Portrait Mode (WIP)#18
IzaakBH wants to merge 30 commits into
mainfrom
portrait-mediapipe

Conversation

IzaakBH commented Jan 12, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Portrait mode with MediaPipe.

IzaakBH commented Jan 12, 2025
View reviewed changes
Comment thread app/src/main/java/co/stonephone/stonecamera/plugins/Portrait.kt Outdated
}
}

fun Bitmap.saveImage(context: Context): Uri? {

IzaakBH Jan 12, 2025

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Long term will just overwrite the saved image, but for now i wanna compare

IzaakBH commented Jan 12, 2025
View reviewed changes
Comment thread app/src/main/java/co/stonephone/stonecamera/utils/ImageSegmenterHelper.kt Outdated

class ImageSegmenterHelper(
var currentDelegate: Int = DELEGATE_CPU,
var runningMode: RunningMode = RunningMode.IMAGE,

IzaakBH Jan 12, 2025

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can set it to process on a live stream instead of images. I wonder if this will be preferable, performance wise, for the live view & how that would tie into the current plugin model?

ISNIT0 mentioned this pull request Jan 13, 2025
Closed
ISNIT0 marked this pull request as draft January 13, 2025 08:43
Use a faster blurring algorithm & refactor to apply mask at blur time
d18a13f 
- Old approach blurred the whole image & then applied the mask which is significantly more computationally expensive
- Also fixing some lint errors

IzaakBH commented Jan 13, 2025

Copy link
Copy Markdown
Collaborator Author

Newly optimised blurring algo takes roughly 700ms on pixel 6a with a large radius of 25 (not including segmentation). Defo further optimisations to be had.

Will focus next on shoving it on a background thread & improving the smoothness of the blur

IzaakBH commented Jan 13, 2025

Copy link
Copy Markdown
Collaborator Author

Newly optimised blurring algo takes roughly 700ms on pixel 6a with a large radius of 25 (not including segmentation). Defo further optimisations to be had.

Will focus next on shoving it on a background thread & improving the smoothness of the blur

Also not 100% happy with the visuals of the blur, but can polish this later after getting the images to save in the correct orientation :D

izaak added 18 commits January 20, 2025 21:36
ISNIT0 reviewed Feb 3, 2025
View reviewed changes
Comment thread app/src/main/java/co/stonephone/stonecamera/plugins/Portrait.kt Outdated
stoneCameraViewModel: StoneCameraViewModel,
outputFileResults: ImageCapture.OutputFileResults
) {
val portraitModeSetting = stoneCameraViewModel.getSetting<String>("portraitMode") ?: "OFF"

ISNIT0 Feb 3, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Do you think we should do this on a "mode" basis?

E.g. extend the Photo Mode plugin? Then there will be a mode option like most other camera apps?

IzaakBH Feb 3, 2025

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yeah I think this would be a good idea. Will make that change

ISNIT0 reviewed Feb 3, 2025
View reviewed changes
Comment thread app/src/main/java/co/stonephone/stonecamera/plugins/Portrait.kt
private fun getOriginalImageRotation(contentResolver: ContentResolver, imageUri: Uri): Int {
val exifInputStream = contentResolver.openInputStream(imageUri)
val exif = ExifInterface(exifInputStream!!)
val rotation = when (exif.getAttributeInt(

ISNIT0 Feb 3, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Should this be more global for all modes? Perhaps I'm mis-understanding

IzaakBH Feb 3, 2025

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The image was being spat out sideways after blurring for some reason. No objection to making it more global

ISNIT0 reviewed Feb 3, 2025
View reviewed changes
Comment thread app/src/main/java/co/stonephone/stonecamera/plugins/Portrait.kt Outdated
)
}

// Stolen from https://stackoverflow.com/questions/21418892/understanding-super-fast-blur-algorithm?fbclid=IwZXh0bgNhZW0CMTEAAR1w91ucNtw4nU-Z8Z9RyMYFVUHWxfgt7ivsE7foTkwR2wmdx2losQqQ0sk_aem_Zrf_8344PRxW6SFzutkE7g

ISNIT0 Feb 3, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

"Borrowed from" 😉

ISNIT0 Feb 3, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Also, isn't there a way we can shift this onto a shader?

IzaakBH Feb 3, 2025

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Not aware of shaders. will take a look

ISNIT0 reviewed Feb 3, 2025
View reviewed changes
Comment thread app/src/main/java/co/stonephone/stonecamera/utils/ImageSegmenterHelper.kt Outdated
import com.google.mediapipe.tasks.vision.imagesegmenter.ImageSegmenterResult

class ImageSegmenterHelper(
var currentDelegate: Int = DELEGATE_CPU,

ISNIT0 Feb 3, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can we make sure we use GPU where possible?

IzaakBH Feb 3, 2025

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I was having trouble w/ gpu but yes, I agree. Will work on making that happen

ISNIT0 reviewed Feb 3, 2025
View reviewed changes
Comment thread app/src/main/java/co/stonephone/stonecamera/utils/ImageSegmenterHelper.kt Outdated
}
}

when(currentModel) {

ISNIT0 Feb 3, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Are all the models included in the build at this stage? How do we strip out the ones we're not using?

IzaakBH Feb 12, 2025

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

They are not, have made changes to remove references to other models

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ISNIT0 ISNIT0 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL