fix: only parse arguments from first line of tag comment (#1650) · TypeScriptToLua/TypeScriptToLua@102a00a · GitHub

TypeScriptToLua / TypeScriptToLua Public

• Notifications You must be signed in to change notification settings
• Fork 187
• Star 2.5k

• Code
• Issues 131
• Pull requests 12
• Actions
• Wiki
• Security and quality
• Insights

Additional navigation options

Commit 102a00a

Browse filesBrowse the repository at this point in the historyBrowse files

aabajyan

authored

fix: only parse arguments from first line of tag comment (#1650)

1 parent d541c9b commit 102a00a
Copy full SHA for 102a00a

3 files changed

+14-1Lines changed: 14 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src/transformation/utils
  • annotations.ts
• test/translation
  • __snapshots__
    • transformation.spec.ts.snap
  • transformation
    • customNameWithExtraComment.ts

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/transformation/utils/annotations.ts‎

Copy file name to clipboardExpand all lines: src/transformation/utils/annotations.ts

+2-1Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -105,7 +105,8 @@ export function getFileAnnotations(sourceFile: ts.SourceFile): AnnotationsMap {
105	105	function getTagArgsFromComment(tag: ts.JSDocTag): string[] {
106	106	if (tag.comment) {
107	107	if (typeof tag.comment === "string") {
108		- return tag.comment.split(" ");
	108	+ const firstLine = tag.comment.split("\n")[0];
	109	+ return firstLine.trim().split(" ");
109	110	} else {
110	111	return tag.comment.map(part => part.text);
111	112	}

Collapse file

‎test/translation/__snapshots__/transformation.spec.ts.snap‎

Copy file name to clipboardExpand all lines: test/translation/__snapshots__/transformation.spec.ts.snap

+2Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -36,6 +36,8 @@ escapedCharsInTemplateString = "\\\\ \\0 \\b \\t \\n \\v \\f \\" ' \`"
36	36	nonEmptyTemplateString = ("Level 0: \\n\\t " .. ("Level 1: \\n\\t\\t " .. ("Level 3: \\n\\t\\t\\t " .. "Last level \\n --") .. " \\n --") .. " \\n --") .. " \\n --""
37	37	`;
38	38
	39	+ exports[`Transformation (customNameWithExtraComment) 1`] = `"TestNamespace.pass()"`;
	40	+
39	41	exports[`Transformation (customNameWithNoSelf) 1`] = `"TestNamespace.pass()"`;
40	42
41	43	exports[`Transformation (exportStatement) 1`] = `

Collapse file

‎test/translation/transformation/customNameWithExtraComment.ts‎

Copy file name to clipboard

+10Lines changed: 10 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -0,0 +1,10 @@
	1	+ /** @noSelf */
	2	+ declare namespace TestNamespace {
	3	+ /**
	4	+ * @customName pass
	5	+ * The first word should not be included.
	6	+ **/
	7	+ function fail(): void;
	8	+ }
	9	+
	10	+ TestNamespace.fail();

0 commit comments

Comments

0 (0)