fix: fix missing dependencies in npm · Urigo/angular-meteor@ccf5eec · GitHub

Urigo / angular-meteor Public

• Notifications You must be signed in to change notification settings
• Fork 603
• Star 2.3k

• Code
• Issues 23
• Pull requests 2
• Actions
• Projects
• Wiki
• Security and quality
• Insights

Additional navigation options

Commit ccf5eec

Browse filesBrowse the repository at this point in the historyBrowse files

Kamil Kisiela

committed

fix: fix missing dependencies in npm

1281 chore: missing external

1 parent 55d21b5 commit ccf5eec
Copy full SHA for ccf5eec

2 files changed

+11-3Lines changed: 11 additions & 3 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• package.json
• webpack
  • common.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎package.json‎

Copy file name to clipboardExpand all lines: package.json

+5-1Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -29,11 +29,15 @@
29	29	"path": "node_modules/cz-conventional-changelog"
30	30	}
31	31	},
	32	+ "dependencies": {
	33	+ "jsondiffpatch": "^0.1.38",
	34	+ "underscore": "^1.0.4"
	35	+ },
32	36	"peerDependencies": {
33	37	"angular": "^1.4.0"
34	38	},
35	39	"devDependencies": {
36		- "babel": "^6.3.26 ",
	40	+ "babel": "^6.3.26",
37	41	"babel-core": "^6.4.5",
38	42	"babel-eslint": "^4.1.6",
39	43	"babel-loader": "^6.2.1",

Collapse file

‎webpack/common.js‎

Copy file name to clipboardExpand all lines: webpack/common.js

+6-2Lines changed: 6 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -19,8 +19,8 @@ var common = {
19	19	// global variables
20	20	externals: {
21	21	angular: 'angular',
22		- underscore: '_',
23	22	jsondiffpatch: 'jsondiffpatch',
	23	+ '_': 'underscore',
24	24	Meteor: 'Meteor',
25	25	Package: 'Package',
26	26	Tracker: 'Tracker'
@@ -50,7 +50,11 @@ var common = {
50	50	},
51	51	plugins: [
52	52	// add information about name and version of angular-meteor package
53		- new webpack.BannerPlugin(pkg.name + ' v' + pkg.version)
	53	+ new webpack.BannerPlugin(pkg.name + ' v' + pkg.version),
	54	+ new webpack.ProvidePlugin({
	55	+ '_': 'underscore',
	56	+ 'jsondiffpatch': 'jsondiffpatch'
	57	+ })
54	58	],
55	59	resolve: {
56	60	extensions: ['', '.js']

0 commit comments

Comments

0 (0)