Commit 7228ca9
committed
fix(cmd): fix with_stdout implementation
Admittedly this fix is solely based on the documentation provided
for this parameter, which indicated a different intend than was
actually implemented. Also I don't believe doing this will cause
any harm.
As a special note: the call to `open(os.devnull, 'wb')` does not seem leak
the handle, apparently it is given as-is to the subprocess, which will then
close it naturally. This was tested using an interactive session via `htop`
on osx.
Fixes gitpython-developers#4371 parent 7a8f96c commit 7228ca9
2 files changed
Lines changed: 3 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -7,6 +7,8 @@ Changelog | |||
| 7 | 7 | ||
| 8 | 8 | * Fix: progress handler exceptions are not caught anymore, which would usually just hide bugs | |
| 9 | 9 | previously. | |
| 10 | + * Fix: The `Git.execute` method will now redirect `stdout` to `devnull` if `with_stdout` is false, | ||
| 11 | + which is the intended behaviour based on the parameter's documentation. | ||
| 10 | 12 | ||
| 11 | 13 | 2.0.2 - Fixes | |
| 12 | 14 | ============= | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -605,7 +605,7 @@ def execute(self, command, | |||
| 605 | 605 | bufsize=-1, | |
| 606 | 606 | stdin=istream, | |
| 607 | 607 | stderr=PIPE, | |
| 608 | - stdout=with_stdout and PIPE or None, | ||
| 608 | + stdout=with_stdout and PIPE or open(os.devnull, 'wb'), | ||
| 609 | 609 | shell=self.USE_SHELL, | |
| 610 | 610 | close_fds=(os.name == 'posix'), # unsupported on windows | |
| 611 | 611 | **subprocess_kwargs | |
0 commit comments