Avoid having to use sudo for running the tests. (#962) · adaptive/docker-python@7d96dee · GitHub

adaptive / docker-python Public

forked from Kaggle/docker-python

• Notifications You must be signed in to change notification settings
• Fork 0
• Star 0

• Code
• Pull requests
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 7d96dee

Browse filesBrowse the repository at this point in the historyBrowse files

rosbo

authored

Avoid having to use sudo for running the tests. (Kaggle#962)

A test run creates files under the /tmp/python-build directory. The owner of these files are the user assigned to your docker process. Running `rm -rf /tmp/python-build` in the test script fails with: ``` rm: cannot remove '/tmp/python-build/working/logs/train_log/events.out.tfevents.1614297217.localhost': Permission denied ... ``` Because your user don't have the permissions to delete these files. Updating the `test` script to delete these files inside the a docker container to circumvent this problem.

1 parent e0a40b7 commit 7d96dee
Copy full SHA for 7d96dee

1 file changed

+2-1Lines changed: 2 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test‎

Copy file name to clipboardExpand all lines: test

+2-1Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -69,7 +69,8 @@ readonly ADDITONAL_OPTS
69	69	readonly PATTERN
70	70
71	71	set -x
72		- rm -rf /tmp/python-build
	72	+ docker run --rm --net=none -v /tmp/python-build:/tmp/python-build "$IMAGE_TAG" rm -rf /tmp/python-build/*
	73	+
73	74	docker rm jupyter_test || true
74	75	mkdir -p /tmp/python-build/tmp
75	76	mkdir -p /tmp/python-build/devshm

0 commit comments

Comments

0 (0)