FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

improve search.ipynb · Issue #714 · aimacode/aima-python · GitHub

Repository navigation

improve search.ipynb #714

Description

Hey @MrDupin , @norvig . I found that I actually implemented greedy best first search algo in my PR #708. So I want to make changes and make it greedy best first search algo and as all the uniform cost search, greedy best first search, a* algos use best first search algo, I would like to remove the repetition of best first algo in the search.ipynb (repeated thrice).
I would also like to add some short documentation explaining the differences between them so that these algorithms will be easily understandable for others. Is it advisable to continue?
Thanks.

Activity

  1. antmarakis commented on Feb 8, 2018

    Collaborator

    Sounds good. I think the search notebook needs an overhaul in general. I will probably create an issue about this next week, but I think the notebook suffers from a lot of repetition and lack of proper structure. If you could cut down on the repetition, it would be great.

    Don't forget that you can use notebook.py to store notebook code that the reads don't really need to see (for example, visualization code).

  2. apb7 commented on Feb 9, 2018

    Contributor

    Hello @MrDupin, I had already created an issue regarding the repetition problem #678. I think we can work on that.
    Thanks!

  3. antmarakis commented on Feb 9, 2018

    Collaborator

    @apb7: Ah yeah, I forgot. Great then, I think cleaning up the search notebook is top priority, so that we can more easily move in the future.

  4. apb7 commented on Feb 9, 2018

    Contributor

    @MrDupin: I think this issue has been fixed in PR #716. We should close it.
    Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions


      Back | FazBrowse Home | New Git URL